feat: Adds Security Ballistic Goggles as a choice in Loadout#898
Open
IdiotWhoPlaysVIPRandGreene wants to merge 3 commits into
Open
feat: Adds Security Ballistic Goggles as a choice in Loadout#898IdiotWhoPlaysVIPRandGreene wants to merge 3 commits into
IdiotWhoPlaysVIPRandGreene wants to merge 3 commits into
Conversation
github-actions
Bot
added
S: Untriaged
size/S
Changes: Sprites
Changes: No C#
Changes: YML
S: Needs Review
and removed
size/S
labels
Contributor
|
RSI Diff Bot; head commit 18652f4 merging into f5c9cdb Resources/Textures/_starcup/Clothing/Eyes/Glasses/Security_Ballistic_goggles.rsi
|
| - type: ShowContrabandDetails | ||
| - type: EyeProtection | ||
| protectionTime: 5 | ||
| tags: |
Member
There was a problem hiding this comment.
YAML linter fail
error in /Prototypes/_starcup/Entities/Clothing/Eyes/glasses.yml(45,5) Field "tags" not found in "Content.Shared.Eye.Blinding.Components.EyeProtectionComponent".
Updates the Glasses File to prevent error involving tags.
for more information, see https://pre-commit.ci
IdiotWhoPlaysVIPRandGreene
changed the title
Contributor
Author
|
Fixed YAML Linter fail and changed the title to fix the issue with the Lint Pull Request title! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of our characters in Starcup hail from the NCWs, or are perhaps more tactically minded then most! Maybe they're conscious of their protection and would much prefer goggles over a small pair of glasses. Or maybe they just like the style of a bulky pair of goggles. This is for the discount Operators of security, those who prefer the old ways, or those who can't quite let go of the wars they fought in.
Why / Balance
The reason I made this was... For the sole reason of looking cool. Other then lore implications about goggles being in surplus after the NCWs, this does not affect balance.
Technical details
Edited Starcup Glasses YMLs to add the goggles, and the Loadout YMLs to include them as a selectable loadout option!
Media
Changelog
🆑