Skip to content

tweak: Increased usability of sustenance vendor#866

Open
bruhmogus wants to merge 8 commits into
teamstarcup:mainfrom
bruhmogus:fix
Open

tweak: Increased usability of sustenance vendor#866
bruhmogus wants to merge 8 commits into
teamstarcup:mainfrom
bruhmogus:fix

Conversation

@bruhmogus
Copy link
Copy Markdown

@bruhmogus bruhmogus commented May 10, 2026

Why / Balance

The sustenance vendor's inventory is pitiful, being empty save for about three items total. You also can't restock it. This fixes that.

Technical details

Added restock just for sustenance vendor, added purchase listing for restock, increased counts of most items in vendor
(all my homies hate git bot)

Media

RUN_THIS.py doesn't do anything useful. It should work!

Changelog
🆑

  • add: Added a Sustenance Vendor restock, which can be purchased for 500 spesos by cargo. Starve no more, prisoners!
  • tweak: Sustenance Vendors come with more items at roundstart.

…ems in vendor, and added restock to cargo purchases
@Psymbiote
Copy link
Copy Markdown
Contributor

Hello! This looks like a good idea to me, I'll ask another team member to give it a review as well. In the meantime, the current title error is fixed by adapting the title so it fits our standard. In this case it would be "tweak: Increased usability of sustenance vendor".

@bruhmogus bruhmogus changed the title Increased usability of sustenance vendor tweak: Increased usability of sustenance vendor May 10, 2026
@Psymbiote
Copy link
Copy Markdown
Contributor

So turns out this was even requested by a team member, I didn't know. I'm not good enough with coding to know what that error is, but if you can fix it, I'll approve it.

@ThebeTheSatellite
Copy link
Copy Markdown
Contributor

ThebeTheSatellite commented May 11, 2026

So I had a look myself, the error is related to the NoCargoOrderArbitrage test failing and going further it looks like due to it not being present in cargo_vending.yml there's an issue. Also keep in mind the potential pricing error
{2590362C-80B3-40D4-9F37-03742EB798F1}

I could have searched wrong or found inconclusive stuff but from what I can tell, it's missing from cargo_vending.yml unlike the rest of the restock crates.
Should be fairly easy to fix, add it to the yml, make sure price is a few hundred lower than the prices of items in the vending machine and you should be wicked.

Side note, pretty sure RUN_THIS.py is only supposed to be used once. For actual testing you need to run to runserver.bat then runclient.bat or the .sh ones if you're not on windows.

@bruhmogus
Copy link
Copy Markdown
Author

So turns out this was even requested by a team member, I didn't know. I'm not good enough with coding to know what that error is, but if you can fix it, I'll approve it.

I DIDNT KNOW THAT EITHER

@bruhmogus
Copy link
Copy Markdown
Author

bruhmogus commented May 11, 2026

So I had a look myself, the error is related to the NoCargoOrderArbitrage test failing and going further it looks like due to it not being present in cargo_vending.yml there's an issue. Also keep in mind the potential pricing error {2590362C-80B3-40D4-9F37-03742EB798F1}

I could have searched wrong or found inconclusive stuff but from what I can tell, it's missing from cargo_vending.yml unlike the rest of the restock crates. Should be fairly easy to fix, add it to the yml, make sure price is a few hundred lower than the prices of items in the vending machine and you should be wicked.

Side note, pretty sure RUN_THIS.py is only supposed to be used once. For actual testing you need to run to runserver.bat then runclient.bat or the .sh ones if you're not on windows.

so from the image it looks like it's making sure cargo can't order a restock, bust it open, and sell it for profit? i can further increase the cost of it if thats the issue (aside from the elephant)

@ThebeTheSatellite
Copy link
Copy Markdown
Contributor

So I had a look myself, the error is related to the NoCargoOrderArbitrage test failing and going further it looks like due to it not being present in cargo_vending.yml there's an issue. Also keep in mind the potential pricing error {2590362C-80B3-40D4-9F37-03742EB798F1}
I could have searched wrong or found inconclusive stuff but from what I can tell, it's missing from cargo_vending.yml unlike the rest of the restock crates. Should be fairly easy to fix, add it to the yml, make sure price is a few hundred lower than the prices of items in the vending machine and you should be wicked.
Side note, pretty sure RUN_THIS.py is only supposed to be used once. For actual testing you need to run to runserver.bat then runclient.bat or the .sh ones if you're not on windows.

so from the image it looks like it's making sure cargo can't order a restock, bust it open, and sell it for profit? i can further increase the cost of it if thats the issue (aside from the elephant)

that makes sense, honestly I couldn't tell if you were meant to increase or decrease the price from the contents but that makes sense pretty sure. thought it was like an in universe profit from the contents. sounds good.

@bruhmogus
Copy link
Copy Markdown
Author

added a listing to cargo_vending.yml, ready for a rereview so tests can start again

@Psymbiote
Copy link
Copy Markdown
Contributor

added a listing to cargo_vending.yml, ready for a rereview so tests can start again

I really need to figure out how to make the tests run automatically

@bruhmogus
Copy link
Copy Markdown
Author

five. hundred. reviews.

@bruhmogus
Copy link
Copy Markdown
Author

I HATE ARBITRAGE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants