Require "node:stream" instead of "stream" #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version accordingly. Also removed package-lock.json and added it to .gitignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And adjust minimum nodejs version accordingly.
Also removed package-lock.json and added it to .gitignore.
Using "node:stream" instead of "stream" enable use of this library in runtimes other than nodejs (e.g.
workerd), at the cost of leaving behind older Nodejs versions.The package-lock.json is unnecessary in a library, especially when not in a monorepo under CI. It generated a lockfile with older versions due to me testing at 14.18.0 and its bundled npm, while I imagine the latest used was newer.