-
Notifications
You must be signed in to change notification settings - Fork 0
Feedback #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-classroom
wants to merge
4
commits into
feedback
Choose a base branch
from
main
base: feedback
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feedback #1
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
[](https://classroom.github.com/a/sQ9gPiKY) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,46 @@ | ||
package assignment; | ||
|
||
public class Set<T> { | ||
public void add(T item) {} | ||
private T[] set = (T[]) new Object[32]; | ||
|
||
public boolean contains(T item) { | ||
public void add(T item) { // O(n) | ||
int firstFreeSpot = -1; // O(1) | ||
for (int i = 0; i < set.length; i++) { // O(n) | ||
if (set[i] == item) { // O(1) | ||
return; | ||
} | ||
if (set[i] == null && firstFreeSpot == -1) { // O(1) | ||
firstFreeSpot = i; // O(1) | ||
} | ||
} | ||
set[firstFreeSpot] = item; // O(1) | ||
} | ||
|
||
public boolean contains(T item) { // O(n) | ||
for (T currentItem : set) { // O(n) | ||
if (currentItem == item) { // O(1) | ||
return true; | ||
} | ||
} | ||
return false; | ||
} | ||
|
||
public void remove(T item) {} | ||
public void remove(T item) { // O(n) | ||
for (int i = 0; i < set.length; i++) { // O(n) | ||
if (set[i] == item) { // O(1) | ||
set[i] = null; // O(1) | ||
return; | ||
} | ||
} | ||
} | ||
|
||
public int size() { | ||
return 0; | ||
public int size() { // O(n) | ||
int nullCount = 0; // O(1) | ||
for (int i = 0; i < set.length; i++) { // O(n) | ||
if (set[i] == null) { // O(1) | ||
nullCount++; // O(1) | ||
} | ||
} | ||
return set.length - nullCount; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an edge case the unit tests don't cover and slightly outside the scope of this assignment, but as an exercise, what would happen if the client attempts to
add()
a new element and the set is already full? What are some reasonable strategies you see to handle such a situation gracefully?