-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor/#99 reject #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor/#99 reject #100
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
b8f8eec
refactor: #99 화이트 배경 삽입
dev-domo 7837cd3
setting: #99 백그라운드 권한 제거
dev-domo ff242b5
setting: #99 위치 권한 설정 문구 추가
dev-domo 3a91055
feat: #99 에플 로그인 시 이름 입력 뷰 건너뛰기
dev-domo 86aa93b
refactor: #99 애플 로그인 시 가져오는 이름 저장
dev-domo 7992517
refactor: #99 scenarioNames가 없는 경우에도 중복 처리가 되지 않도록 방지
dev-domo b7ecbc9
feat: #99 weatherKit 로고 및 링크 삽입
dev-domo 1c64b46
refactor: #99 홈 등록된 시나리오가 없을 때 뷰 수정
dev-domo df72143
refactor: #99 weatherKitButtonView에 탭 제스처 추가
dev-domo 1c36676
refactor: #99 LoginResponseDTO 필드 추가
dev-domo 908f141
refactor: #99 카카오 SDK 초기화 로직 함수 분리
dev-domo f2ddf4b
refactor: #99 동시 바인딩 적용을 통한 날씨 업데이트 속도 증진
dev-domo 0dd1c5b
refactor: #99 메서드명 수정 및 메서드 분리
dev-domo b340462
refactor: #99 구조적 동시성 구현 방법 변경
dev-domo 72ef72c
refactor: #99 WeatherKit 로고 탭 제스처 등록 로직을 setGesture 메서드로 이동
dev-domo 4c6c6c6
refactor: #99 불필요한 메서드 분리 수정
dev-domo 8ea0a97
refactor: UISwipeActionsConfiguration 생성 방식 수정
dev-domo 3164fa2
refactor: #99 드래그 동작 추상화
dev-domo aaab10b
refactor: #99 드래그 동작 싱글턴 클래스 구현
dev-domo df0e633
refactor: #99 드래그 동작 핸들러 파일명 및 폴더링 수정
dev-domo 506efde
refactor: #99 테이블뷰 Drop 동작 공통 메서드 분리
dev-domo 1cd46ec
refactor: #99 UITableViewDragDelegate 확장으로 수정
dev-domo 912a996
refactor: #99 테이블뷰의 스와이프 삭제 기능을 프로토콜화
dev-domo 427fbae
feat: #99 유저 이름 조회 API 연동
dev-domo 1aa1bda
refactor: #99 약관동의 완료 여부, 온보딩 완료 여부를 관리하지 않도록 수정
dev-domo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isAgreedTerms(accessToken:)함수가TermsRepository에도 동일하게 구현되어 있어 코드 중복이 발생했습니다. 약관 관련 로직은TermsRepository에서 관리하는 것이 역할 분리 측면에서 더 적절해 보입니다.TermsRepository의isAgreedTerms함수를public으로 변경하고,AuthRepository에서는TermsInterface를 통해 해당 함수를 호출하여 사용하는 방식으로 리팩토링하면 중복을 제거하고 코드 유지보수성을 높일 수 있습니다.