Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing cross-base link fields when update dbTableName #1200

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

tea-artist
Copy link
Contributor

@tea-artist tea-artist commented Dec 28, 2024

image

If the current table is associated with the link field or lookup field of another base, modifying dbTableName will lead to a 500 error in modifying the link field cell.

In the original code, when updating the database name, the fkHostTableName in the relevant link field and lookup field was updated. However, the code query condition restricts only querying the field information under the current baseId. But since the cross-base link was introduced later, the fkHostTableName may come from different bases. At this time, a query of global fields is needed to ensure that the modification is correct.

@tea-artist tea-artist force-pushed the fix/update-db-table-name branch from 6f76395 to 935d424 Compare December 28, 2024 16:34
@tea-artist tea-artist added the preview This issue is already ready for preview label Dec 28, 2024
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1200.sealosgzg.site

@tea-artist tea-artist merged commit 6dacd39 into develop Dec 29, 2024
14 of 15 checks passed
@tea-artist tea-artist deleted the fix/update-db-table-name branch December 29, 2024 07:07
Copy link

🧹 Preview Environment Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview This issue is already ready for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant