-
Notifications
You must be signed in to change notification settings - Fork 8
fix razer blade 2023 #17
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, the change as is can not be merged.
The last letter in model_number_prefix
matters. E.g. it can differentiate AMD and Intel laptops, black and mercury colors, etc. Those will have a different set of supported features, and even the same feature might have a different implementation.
@@ -24,7 +24,7 @@ pub const SUPPORTED: &[Descriptor] = &[ | |||
], | |||
}, | |||
Descriptor { | |||
model_number_prefix: "RZ09-0482X", | |||
model_number_prefix: "RZ09-0482", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
model_number_prefix
is an entry from the list provided by Razor. According to it RZ09-0482X
and RZ09-0482V
are different models.
And they do different. They have a different set of supported features, e.g.
RZ09-0482X
- Mercury and doesn't have a LED Logo on the lidRZ09-0482V
- Black and has Logo on the lid
I suggest adding extra entry to the SUPPORTED
array. If there are cases where model_number_prefix
es share common set of features, the model_number_prefix
entry can be refactored into array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok....
mine is ->
PS D:\source\repos\razer-ctl\target\debug> .\razer-cli.exe enumerate
Model: RZ09-0483S
Supported: true
PID: [
0x029f,
]
btw. i use RustRover to build the project.
with you exe file i also got the HID error. compiled with RustRover its works.
maybe it use newer/other libs ;)
and btw2 big thx for your work. i dont need synapse anymore. the only thing i miss is changing the color of the keyboard...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
synapse is a nightmare 🌃.
changing keyboard colors was requested multiple times, but I believe it should be a standalone tool, as not everyone has Razer keyboard.
re: compilation issues, just did clean clone and ran
❯ cargo run --release --target x86_64-pc-windows-gnu --bin razer-cli enumerate
Finished `release` profile [optimized] target(s) in 0.05s
Running `target/x86_64-pc-windows-gnu/release/razer-cli.exe enumerate`
Model: RZ09-0483T
Supported: true
PID: [
0x029f,
]
Feel free to add your model, RZ09-0483S,
to the list of SUPPORTED,
and PR is good to merge.
No description provided.