-
Couldn't load subscription status.
- Fork 134
Add mdx support to cli #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
As MDX is a superset of markdown, perhaps this library could look for md and mdx files directly (without the need of an extra parameter) @tcort @WillGibson @BaseMax any thought about that ? |
|
@TudorCRL could you make changes to search for .md or .mdx files without the need of an extra option ? |
|
Without any answer by this weekend, I will close this PR without merging and create the changes myself |
|
Hi @smainil, apologies for not getting back to you, just got back from holiday! I'm happy to make that change, just one thought on that is that this change causes the checker to pick up on links that it previously would have ignored so won't be backwards compatible. But if you're fine with that I can push that change soon |
|
This pull request has been marked as stale because it has been open 60 days with no activity. It will be closed in 30 days unless the stale label is removed or someone adds a comment. |
|
No update? |
|
This pull request has been marked as stale because it has been open 60 days with no activity. It will be closed in 30 days unless the stale label is removed or someone adds a comment. |
What is MDX?An MDX file is a file format that combines Markdown and JSX (JavaScript XML), allowing for the embedding of interactive components within Markdown documents. This means you can write content using Markdown's familiar syntax while also incorporating React components directly into the text. |
|
As we also have another PR for supporting qmd file extension (#478) maybe we should allow users to set a list of file extensions (.md would be set by default if not provided). Will try to have a look into it |
|
This branch has conflicts that must be resolved |
|
cc @TudorCRL |
Add a new option to the CLI tool
--include-mdx. When running the CLI, check .mdx files if --include-mdx is set to true.@tcort I don't know if you'd be interested in including this as a feature? We need it at my org for our internal checks on our docs, let me know what you think