Skip to content

Fixes trimming for windows. \r\n are not trimmed when using TrimSuffix #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmeyers22 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixes trimming for windows. \r\n are not trimmed when using TrimSuffix #14

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da82c9b
Fixes trimming for windows. \r\n are not trimmed when using TrimSuffix
bmeyers22 Sep 21, 2017
da25fc4
Updated tests to reflect new code
bmeyers22 Sep 21, 2017
9fc3518
STUD-785 Added WK CI
joecotton-wk Aug 11, 2022
2239ada
STUD-785 Added tool dependency to unit tests
joecotton-wk Aug 12, 2022
7eec9f1
Merge pull request #2 from Workiva/release-v0.0.1
rmconsole3-wf Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions read.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ func (i *UI) read(opts *readOptions) (string, error) {
resultErr = fmt.Errorf("failed to read the input: %s", err)
}

resultStr = strings.TrimSuffix(line, LineSep)
resultStr = strings.Trim(line, LineSep)
// brute force for the moment
resultStr = strings.TrimSuffix(line, "\n")
resultStr = strings.TrimSuffix(resultStr, "\n")
Copy link
Author

@bmeyers22 bmeyers22 Sep 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I'm not sure of the reasoning for this line so I left it in, but I'm guessing you needed it to get rid of new lines no matter what since they probably weren't working for windows. Using Trim instead of TrimSuffix should solve this problem, so you may be able to remove this line

}
}()

Expand Down