Intl Era Monthcode: Constrain tests for Hebrew calendar #4725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests for constraining 30 Adar I to 29 Adar when moving from a leap year to a common year, by the add(), subtract(), or with() methods. Constraining of the month code is already tested in leap-months-hebrew.js.
This adds tests for constraining the day when adding years and months in the Hebrew calendars. Test that 30 gets constrained to 29 in 29-day months. There are special test cases for the variable lengths of Cheshvan (M02) and Kislev (M03).
ptomato
force-pushed
the
hebrew-calendar-constrain
branch
from
e9efc1b to
9f53e51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various tests for constraining day 30 of a month to day 29 when landing in a different month.
As usual, I recommend reviewing
PlainDate/prototype/add/andPlainDate/prototype/with/carefully and spot-checking the others, which are very similar.