Skip to content

Intl Era Monthcode: Era code updates for CLDR 48 #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Intl Era Monthcode: Era code updates for CLDR 48 #4660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions test/intl402/DateTimeFormat/prototype/formatToParts/era.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ features: [Intl.Era-monthcode]

const multipleEraTests = [
["gregory", [-100, 2025]],
["islamic-civil", [600, 2025]],
["islamic-tbla", [600, 2025]],
["islamic-umalqura", [600, 2025]],
["japanese", [-100, 1850, 1880, 1920, 1930, 1990, 2025]],
["roc", [1900, 2025]],
];
Expand Down Expand Up @@ -45,10 +48,44 @@ for (const [calendar, isoYears] of multipleEraTests) {
assert.sameValue(new Set(eras).size, eras.length, `${calendar} eras (${eras.join(",")}) should be unique`);
}

// Test that ethopic has two distinct eras and the first one encompasses both
// negative and positive years
{
const formatter = new Intl.DateTimeFormat("en", {
calendar: "ethiopic",
era: "long",
year: "numeric",
});

const eras = [];

for (const isoYear of [-6000, 0, 2025]) {
const date = new Date(isoYear, 5, 15);
const parts = formatter.formatToParts(date);

const eraPart = parts.find(({ type }) => type === "era");
assert.notSameValue(eraPart, undefined, `Format of ethiopic ISO ${isoYear} should have era part`);
assert.sameValue(typeof eraPart.value, "string", `Era format of ethiopic ISO ${isoYear} should be a string`);
assert(eraPart.value.length > 0, `Era format of ethiopic ISO ${isoYear} should not be empty`);
eras.push(eraPart.value);

const format = formatter.format(date);
assert(format.includes(eraPart.value), `${format} should include ${eraPart.value} era`);

const yearPart = parts.find(({ type }) => type === "year");
assert.notSameValue(yearPart, undefined, `Format of ethiopic ISO ${isoYear} should have year part`);
}

assert.sameValue(eras[0], eras[1], "Ethiopic AA era for both positive and negative years");
assert.notSameValue(eras[0], eras[2], "Ethopic AA and AM eras are distinct");
}


// Calendars with a single era: test one year occurring before and one after the
// single era's epoch
const singleEraTests = [
["buddhist", [-600, 2025]],
["coptic", [250, 2025]],
["ethioaa", [-5550, 2025]],
["hebrew", [-3800, 2025]],
["indian", [70, 2025]],
Expand Down