Scopes: Refactor scopes tree decoding #220
Merged
+178
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
changed the title
|
I just noticed that this makes FlattenedScopes in post-order rather than pre-order, I need to fix that. |
szuend
requested changes
Aug 29, 2025
szuend
approved these changes
Sep 2, 2025
| 1. If |OriginalScopeVariablesItem| is present, then | ||
| 1. Set _originalScope_.[[Variables]] to the OriginalScopeVariables of |OriginalScopeVariablesItem| with arguments _state_.[[ScopeVariableIndex]] and _names_. | ||
| 1. If |OriginalScopeItemList| is present, then | ||
| 1. Set _originalScope_.[[Children]] to the DecodedOriginalScopeTrees of |OriginalScopeItemList| with arguments _state_ and _names_. |
There was a problem hiding this comment.
Should this be DecodeInnerOriginalScopeTrees?
szuend
reviewed
Sep 2, 2025
| 1. Let _childScope_ be DecodeOriginalScope(|OriginalScopeTree|, _state_, _names_). | ||
| 1. Append _childScope_ to _scope_.[[Children]]. | ||
| 1. Let _left_ be the DecodedOriginalScopeTrees of |OriginalScopeItemList| with arguments _state_ and _names_. | ||
| 1. Let _right_ be the DecodedOriginalScopeTrees of |OriginalScopeItem| with arguments _state_ and _names_. |
There was a problem hiding this comment.
Also here probably DeocdeInnerOriginalScopeTrees.
|
Thanks! lgtm % a minor bug. As a suggestion: We could flip the naming. So instead of having |
|
Fixed and renamed. Merging! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally opened at szuend#1. See #196 (comment).
I tried to make it a bit easier to see what is going on by:
We could do something similar for TopLevelItemList.