Normative: Add missing function name for Iterator.prototype[Symbol.toStringTag] accessors #3621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…StringTag] accessors The function name must be explicitly specified for methods whose property key is a Symbol value.
|
JSC doesn't assign the expected name: >>> Object.getOwnPropertyDescriptor(Iterator.prototype, Symbol.toStringTag).get.name
"get "
>>> Object.getOwnPropertyDescriptor(Iterator.prototype, Symbol.toStringTag).set.name
"set " |
|
oof. does test262 not have tests covering the name? |
|
I don't think there's test262 coverage for this. Or at least I don't see any coverage in https://github.com/tc39/test262/tree/main/test/built-ins/Iterator/prototype/Symbol.toStringTag. (I'm currently exploring if it's possible to generate tests for |
michaelficarra
added
normative change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function name must be explicitly specified for methods whose property key is a Symbol value.