Skip to content

Errored modules have an empty [[CycleRoot]] #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Errored modules have an empty [[CycleRoot]] #3583

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b42e0c2
Relax assumption abuot [[CycleRoot]] being a module on evaluated module
nicolo-ribaudo May 1, 2025
02a710f
Update assertion
nicolo-ribaudo Oct 20, 2025
75b9cef
Fix
nicolo-ribaudo Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27106,7 +27106,11 @@ <h1>Evaluate ( ): a Promise</h1>
<emu-alg>
1. Assert: This call to Evaluate is not happening at the same time as another call to Evaluate within the surrounding agent.
1. Assert: _module_.[[Status]] is one of ~linked~, ~evaluating-async~, or ~evaluated~.
1. If _module_.[[Status]] is either ~evaluating-async~ or ~evaluated~, set _module_ to _module_.[[CycleRoot]].
1. If _module_.[[Status]] is either ~evaluating-async~ or ~evaluated~, then
1. If _module_.[[CycleRoot]] is not ~empty~, then
1. Set _module_ to _module_.[[CycleRoot]].
1. Else,
1. Assert: _module_.[[Status]] is ~evaluated~ and _module_.[[EvaluationError]] is a throw completion.
1. If _module_.[[TopLevelCapability]] is not ~empty~, then
1. Return _module_.[[TopLevelCapability]].[[Promise]].
1. Let _stack_ be a new empty List.
Expand Down
Loading