Updated software #10
Open
Updated software #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reverted others to original source for COPY
tbeadle
requested changes
Mar 23, 2020
| @@ -4,6 +4,11 @@ deployment of WSGI applications a breeze. There are Dockerfiles to build images | |||
| that can be used when the appication is written for Python 2.7 or 3.5. You | |||
| *are* using Python 3.5+, right? | |||
|
|
|||
| ## Credit to the creator | |||
There was a problem hiding this comment.
These changes in README.md shouldn't really go in my repo here.
| @@ -2,12 +2,12 @@ | |||
|
|
|||
| set -eo pipefail | |||
|
|
|||
| repo=tbeadle/gunicorn-nginx | |||
| repo=adaminfinitum/gunicorn-nginx | |||
There was a problem hiding this comment.
This change also shoudln't get merged in to this repo.
| @@ -0,0 +1,12 @@ | |||
| FROM adaminfinitum/gunicorn-nginx:3.8 | |||
There was a problem hiding this comment.
If this were to be merged in to this repo, it should be tbeadle/gunicorn....
| PACKAGE_JSON=/app/docker/package.json | ||
| PACKAGE_JSON=/app/docker/package.json \ | ||
| PYTHONDONTWRITEBYTECODE=1 \ | ||
| PYTHONUNBUFFERED=1 \ |
There was a problem hiding this comment.
Looks like some indentation issue here. spaces vs. tabs maybe?
Comment on lines
+25
to
+26
| PORT=8080 \ | ||
| HOST=0.0.0.0 |
There was a problem hiding this comment.
I think these should get exposed via build arguments. https://docs.docker.com/engine/reference/builder/#arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will be a few settings you'll probably want to change back as I configured the compatible repos to work on Google Cloud Run which requires PORT8080. But I went ahead and updated Debian to Buster and the latest versions of all the major included libraries.