Skip to content

Commit

Permalink
chore(tools/depotfmt): use Go version from buildGo
Browse files Browse the repository at this point in the history
This is required because Go 1.18 is actually being deleted. I've
applied the formatting breakage that it introduces (such as breaking
comment formatting), because I can't be bothered to try and work
around broken Go stuff.

Change-Id: Ica7cee0d01228845d6a766079fef36df99a3da96
Reviewed-on: https://cl.tvl.fyi/c/depot/+/9832
Autosubmit: tazjin <[email protected]>
Reviewed-by: flokli <[email protected]>
Tested-by: BuildkiteCI
  • Loading branch information
tazjin authored and clbot committed Oct 30, 2023
1 parent 6a4b4e3 commit 0d880c6
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions layers/layers.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
//
// # Inputs
//
// * a graph of Nix runtime dependencies, generated via exportReferenceGraph
// * popularity values of each package in the Nix package set (in the form of a
// direct reference count)
// * a maximum number of layers to allocate for the image (the "layer budget")
// - a graph of Nix runtime dependencies, generated via exportReferenceGraph
// - popularity values of each package in the Nix package set (in the form of a
// direct reference count)
// - a maximum number of layers to allocate for the image (the "layer budget")
//
// # Algorithm
//
Expand All @@ -30,14 +30,15 @@
// │ │
// │ v
// └───> D ───> F
// │
// └────> G
//
// │
// └────> G
//
// Each node (i.e. package) is then visited to determine how important
// it is to separate this node into its own layer, specifically:
//
// 1. Is the node within a certain threshold percentile of absolute
// popularity within all of nixpkgs? (e.g. `glibc`, `openssl`)
// 1. Is the node within a certain threshold percentile of absolute
// popularity within all of nixpkgs? (e.g. `glibc`, `openssl`)
//
// 2. Is the node's runtime closure above a threshold size? (e.g. 100MB)
//
Expand Down

0 comments on commit 0d880c6

Please sign in to comment.