fix(uv): Install missing uvicorn dependency #306
Draft
+925
−763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes [ERROR] Unexpected error running server: 'websockets-sansio' [1] - Run uv lock to freeze dependency versions - Use multi-stage docker build (512M -> 340M) [2] [1] jlowin/fastmcp#2299 [2] https://github.com/astral-sh/uv-docker-example/blob/fa761744819c05f4ce207bde1f0a396f6be3915f/multistage.Dockerfile
Owner
|
Not sure what the idea is here but this is a totally different approach and uvicorn is already a dependency we pull through fastmcp |
Author
Oh right, I did not see that the first reference actually belongs to the FastMCP project itself. Please let me know if you're fine with the Dockerfile change, I'll either rebase or open a different PR for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ERROR] Unexpected error running server: 'websockets-sansio'[1]uv lockto freeze dependency versions[1] jlowin/fastmcp#2299
[2] https://github.com/astral-sh/uv-docker-example/blob/fa761744819c05f4ce207bde1f0a396f6be3915f/multistage.Dockerfile