added conditional check to only initialize messenger instance once#19
Open
marcel-matchory wants to merge 1 commit intotawk:mainfrom
Open
added conditional check to only initialize messenger instance once#19marcel-matchory wants to merge 1 commit intotawk:mainfrom
marcel-matchory wants to merge 1 commit intotawk:mainfrom
Conversation
|
@jaoaustero would you be able to review this PR anytime soon? We have to continuously run off a fork right now :( |
|
Okay, I've resorted to creating the Vue plugin directly in our application and removed this package. If it helps anyone; I've written it in TypeScript:
|
jao-tawk
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing the plugin according to the docs to a Vue SPA, the messenger instance is mounted once per component. This results in tens or even hundreds of embedded tawk scripts and eventually messes with app performance. This tiny change makes sure the messenger instance is only embedded once.
Additionally, we changed the tawk messenger property on Vue components to hold the tawk messenger instance instead of the Vue instance, which was probably a bug, anyway.