-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(core): allow config app dir override #14620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat(core): allow config app dir override #14620
Conversation
Package Changes Through a08aa1eThere are 3 changes which include tauri with minor, tauri-macos-sign with patch, tauri-bundler with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| /// - **Windows:** Resolves to [`local_data_dir`](Self::local_data_dir)`/${bundle_identifier}/logs`. | ||
| pub fn app_log_dir(&self) -> Result<PathBuf> { | ||
| if let Some(app_directories_override) = self.app_directories_override() { | ||
| return Ok(app_directories_override?.join("logs")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much open to suggestion on those paths, and we could document them once settled
|
This either needs to be windows only or have more warnings. Once you package the app on Linux and macOS most paths won't work anymore while on Windows they'd still work (on perUser installs). Speaking about paths, would it make sense to still resolve the For Linux another one like |
So my original idea was to only use this in non-packaged environment like portable apps and during debugging (in
Most of the paths still need to work I think, people might want to access those directories not just for storing their own data?
Nice call, I'll change it to use |
I meant in the new path config, so you could say your override should be somewhere on the Desktop or in the Documents dir.
totally forgot that's a thing x) |
Ah I see what you mean now, good idea I guess |
Reference: #3109
Closes tauri-apps/plugins-workspace#3020
We could still do tauri-apps/plugins-workspace#3022 by changing
filenameto take a path (which can be relative)