[STEP 2] rookie, uno, poodle #14
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| // | ||
| // ExhibitionViewController.swift | ||
| // Expo1900 | ||
| // | ||
| // Created by 임채윤 on 2022/10/04. | ||
| // | ||
|
|
||
| import UIKit | ||
|
|
||
| class ExhibitionViewController: UIViewController { | ||
| @IBOutlet weak var workPieceItemTableView: UITableView! | ||
| @IBOutlet weak var navigationBarItem: UINavigationItem! | ||
|
|
||
| var workPieceInformationData = [WorkPieceInformation]() | ||
|
|
||
| let cellName = "workPieceItemCell" | ||
|
Contributor
There was a problem hiding this comment. cell identifier를 상수로 저장한 부분 너무 좋습니다 👍 |
||
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| workPieceInformationJsonParsingData() | ||
| workPieceItemTableView.delegate = self | ||
| workPieceItemTableView.dataSource = self | ||
| } | ||
|
|
||
| func workPieceInformationJsonParsingData() { | ||
|
Contributor
There was a problem hiding this comment. Main VC에서 언급했던 내용처럼 파싱 모델을 만들어서 구현해보면 좋을 거같아요! |
||
| let jsonDecoder = JSONDecoder() | ||
| guard let dataAsset = NSDataAsset(name: "items"), | ||
| let data = try? jsonDecoder.decode([WorkPieceInformation].self, from: dataAsset.data) else { return } | ||
|
|
||
| workPieceInformationData = data | ||
| } | ||
|
|
||
| override func viewWillAppear(_ animated: Bool) { | ||
|
Contributor
There was a problem hiding this comment. viewDidLoad 메서드와 다른 위치에 있군요! |
||
| navigationBarItem.title = "한국의 출품작" | ||
| self.navigationController?.navigationBar.isHidden = false | ||
| } | ||
|
|
||
| override func prepare(for segue: UIStoryboardSegue, sender: Any?) { | ||
| if segue.identifier == "workPieceItemDetail" { | ||
|
Contributor
There was a problem hiding this comment. segue의 identifier를 통해 데이터를 전달했군요! 지금 방식도 틀리지는 않습니다 !! 😀 |
||
| if let destination = segue.destination as? WorkPieceItemViewController { | ||
| if let selectedIndex = self.workPieceItemTableView.indexPathForSelectedRow?.row { | ||
| destination.prepareImage = workPieceInformationData[selectedIndex].imageName | ||
| destination.prepareDescriptionLabel = workPieceInformationData[selectedIndex].description | ||
| destination.prepareTitleName = workPieceInformationData[selectedIndex].name | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension ExhibitionViewController: UITableViewDataSource, UITableViewDelegate { | ||
| func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int { | ||
| return workPieceInformationData.count | ||
| } | ||
|
|
||
| func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell { | ||
| guard let workPieceItemCell = workPieceItemTableView.dequeueReusableCell(withIdentifier: cellName, for: indexPath) as? WorkPieceItemTableViewCell else { return UITableViewCell() } | ||
|
|
||
| workPieceItemCell.workPieceItemImageView.image = UIImage(named: workPieceInformationData[indexPath.row].imageName) | ||
|
Contributor
There was a problem hiding this comment. 커스텀 셀 타입에서 메서드를 통해 조금 더 간결하게 표현해보세요!! 💪 |
||
| workPieceItemCell.workPieceItemTitleLabel.text = workPieceInformationData[indexPath.row].name | ||
| workPieceItemCell.workPieceItemDescriptionLabel.text = workPieceInformationData[indexPath.row].shortDescription | ||
|
|
||
| return workPieceItemCell | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
파일위치를 수정하면 좋을 거같아요! 커스텀 셀과 앱,씬 딜리게이트, 뷰컨트롤러들끼리 섞여있군요!