Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow): only validate pending dependencies when moving to completed #3164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roggervalf
Copy link
Collaborator

Why

  1. Why is this change necessary? When parent is moved to failed, error should be saved saved, even if there are pending dependencies. As it will be moved to failed anyway, better to preserve the real error. Pending dependencies must be validated only when trying to move a parent to completed

How

  1. How did you implement this? Before validating the quantity of pending dependencies, check that we are trying to move parent to completed

Additional Notes (Optional)

Any extra info here.

@roggervalf roggervalf changed the title fix(flow): only validate pending dependencies when moving to completed fix(flow): only validate pending dependencies when moving to completed (DRAFT) Mar 21, 2025
@roggervalf roggervalf force-pushed the fix-pending-children-completed branch from 6d5050c to 26d67c7 Compare March 22, 2025 01:24
@roggervalf roggervalf changed the title fix(flow): only validate pending dependencies when moving to completed (DRAFT) fix(flow): only validate pending dependencies when moving to completed Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant