ci: run PR checks on merge_group so the merge queue works#151
Merged
Conversation
The repo's branch ruleset enables a merge queue and requires the `Test` status check, but `pr-check.yml` only triggered on `pull_request`/`workflow_dispatch`. When a PR enters the queue, GitHub dispatches a `merge_group` event on the queue branch; with no workflow listening for it, `Test` never runs there and the queue entry stalls in AWAITING_CHECKS until the 60-minute timeout, so nothing can merge. Add the `merge_group` trigger so the required `Test` (and licenses) jobs run on the queue branch and the queue can complete merges. Note: because GitHub only fires `merge_group` for workflows present on the default branch, this PR cannot validate through the queue itself and must be merged once via admin/bypass. Subsequent PRs will merge normally. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo's
mainbranch ruleset enables a merge queue (SQUASH,ALLGREEN) and requires theTeststatus check. However,pr-check.ymlonly triggered onpull_requestandworkflow_dispatch.When a PR is added to the queue, GitHub creates a
gh-readonly-queue/main/...branch and dispatches amerge_groupevent. With no workflow listening for that event, the requiredTestcheck never runs on the queue branch, so the queue entry sits inAWAITING_CHECKSuntil the 60-minute timeout — nothing can merge through the queue. (This is exactly what happened to #150, which had to be merged manually.)Fix
Add the
merge_grouptrigger topr-check.yml:Now the
Test(andfile licenses) jobs run on the queue branch, the queue sees the required check report green, and merges complete.GitHub only fires
merge_groupfor workflows that exist on the default branch. Sincemaindoesn't yet contain this trigger, the queue still can't validate this PR — it will stall like the others. This PR must therefore be merged once via admin/bypass (org admins havebypass_mode: alwayson the ruleset). Every PR after this lands onmainwill merge through the queue normally.Docs/CI-config only; no application code changes.
🤖 Generated with Claude Code