Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix download artifact vulnerability #327

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

DifferentialOrange
Copy link
Member

@DifferentialOrange DifferentialOrange commented Sep 4, 2024

Versions of actions/download-artifact before 4.1.7 are vulnerable to arbitrary file write when downloading and extracting a specifically crafted artifact that contains path traversal filenames [1].

  1. https://github.com/tarantool/tarantool-python/security/dependabot/4

Also see #326

Since CI is failing now, several fixes were introduced, as well as Python 3.6 support drop.

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/no-gh-ci-health branch 2 times, most recently from 41b052f to f85f3c5 Compare September 4, 2024 06:36
@DifferentialOrange DifferentialOrange changed the title Differential orange/no gh ci health ci: fix download artifact vulnerability Sep 4, 2024
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/no-gh-ci-health branch from 093813b to 31666d9 Compare September 4, 2024 06:56
Versions of actions/download-artifact before 4.1.7 are vulnerable to
arbitrary file write when downloading and extracting a specifically
crafted artifact that contains path traversal filenames [1].

1. https://github.com/tarantool/tarantool-python/security/dependabot/4
After this patch, current PR pipeline runs will be cancelled if new
commits/force push triggers new pipelines.
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/no-gh-ci-health branch from 31666d9 to af88d26 Compare September 4, 2024 08:09
Python 3.6 EOL is 2021-12-23 [1]. Current build script no longer
supports Python 3.6 due to `packaging` Python dependency bump.
(And fixing the issue is more than just fixating older `packaging`
version as a dependency.)

https://devguide.python.org/versions/
@DifferentialOrange DifferentialOrange merged commit 61e96fc into master Sep 18, 2024
75 checks passed
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/no-gh-ci-health branch September 18, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants