-
Notifications
You must be signed in to change notification settings - Fork 0
driver: implement TCS driver for tarantool support #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Introduce a new Tarantool TKV driver and align core interfaces and models to support it
- Add TKV driver with transactional execution and key watch support
- Adjust driver interfaces (Watch signature) and data models (KeyValue, RequestResponse) for compatibility
- Add integration tests against a Tarantool instance and update dependencies and lint configuration
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| driver/tkv/tkv.go | Implements TKV driver Execute and Watch, wiring to Tarantool watcher API. |
| driver/tkv/txn.go | Defines request/response encoding/decoding and maps Tarantool responses to tx.Response. |
| driver/tkv/operations.go | Encodes operations (get/put/delete) for TKV. |
| driver/tkv/predicate.go | Encodes predicates and maps ops/targets to TKV equivalents. |
| driver/tkv/integration_test.go | Integration tests validating put/get/delete, predicates, multi-op, and watch behavior. |
| driver/driver.go | Changes Watch API to return a channel, a stop function, and an error. |
| driver/etcd/etcd.go | Updates Watch signature to match the new Driver interface. |
| watch/event.go | Simplifies Event to contain only Prefix. |
| tx/requestresponse.go | Refactors RequestResponse to hold a slice of KeyValue values. |
| kv/kv.go | Removes CreateRevision and Version fields; keeps ModRevision. |
| internal/mocks/driver_mock.go | Updates mocks to match the new Watch signature. |
| go.mod | Adds msgpack/v5 as a direct dependency. |
| .golangci.yml | Allows msgpack imports and tarantool packages in tests. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
7531a92 to
c5c3cb7
Compare
Pull Request Test Coverage Report for Build 19100749657Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
870c579 to
2df1217
Compare
2df1217 to
2c88b0b
Compare
2c88b0b to
1d5d4ed
Compare
oleg-jukovec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, rename TKV -> TcS or TCS everywhere.
oleg-jukovec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update the CI impl commit title & message.
oleg-jukovec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a nice idea to start the CHANGELOG.md here. Or you could it fill on the first release. Up to you.
5414399 to
bdd88e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bdd88e7 to
3d42b92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
16fb273 to
1b7f28b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1b7f28b to
e2cc7fa
Compare
|
Please, change the PR title: tkv-> TCS. |
elhimov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch! Please, see my comments.
e2cc7fa to
e33c394
Compare
- New Tarantool Config Storage (TCS) driver package (driver/tcs). - Integration testing for TCS. - Updated .golangci.yml. - Modified core driver interfaces to be compatible with tcs. - Update go module dependencies. Closes #TNTP-4188
e33c394 to
52b2827
Compare
Closes #TNTP-4188