go-prompt: fix update completion data #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmyger
force-pushed
the
dmyger/gh-944-fix-update-competion-data
branch
from
3c05b6b to
cc02710
Compare
dmyger
force-pushed
the
dmyger/gh-944-fix-update-competion-data
branch
from
c7ebd98 to
3bbf8fd
Compare
oleg-jukovec
approved these changes
Oct 7, 2024
oleg-jukovec
reviewed
Oct 7, 2024
oleg-jukovec
reviewed
Oct 7, 2024
The issue that in `GetSelectedSuggestion()` there is no checks that index in valid range. So here we are resetting `selected` index, if length of new array is less, than it was. Part of tarantool/tt#944
dmyger
force-pushed
the
dmyger/gh-944-fix-update-competion-data
branch
from
3bbf8fd to
a8e4996
Compare
oleg-jukovec
reviewed
Oct 8, 2024
themilchenko
approved these changes
Oct 8, 2024
oleg-jukovec
added a commit
that referenced
this pull request
Oct 8, 2024
Fixed * Crash after a completion update with a smaller suggestion (#14).
Merged
oleg-jukovec
added a commit
that referenced
this pull request
Oct 9, 2024
Fixed * Crash after a completion update with a smaller suggestion (#14).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue that in
GetSelectedSuggestion()there is no checks that index in valid range. So here we are resettingselectedindex, if length of new array is less, than it was.Part of tarantool/tt#944