fix: Remove log-level escalation for 4xx/5xx in access log#400
Merged
tarampampam merged 3 commits intomasterfrom May 4, 2026
Merged
fix: Remove log-level escalation for 4xx/5xx in access log#400tarampampam merged 3 commits intomasterfrom
tarampampam merged 3 commits intomasterfrom
Conversation
Update comments for
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the middleware bumped the log level to
warnfor 4xx anderrorfor 5xx responses. Sinceerror-pagesis purpose-built to serve error pages, every normal request produces a 4xx/5xx response (with enabled--send-same-http-code) - making those elevated log entries pure noise (see #397).The middleware now always logs at the caller-configured level (
info) with a uniformRequest successfully processedmessage.