Skip to content

Add Copilot as non-blocking reviewer - #2

Merged
xdanger merged 3 commits into
mainfrom
add-copilot-reviewer
Mar 28, 2026
Merged

xdanger merged 3 commits into
mainfrom
add-copilot-reviewer

Conversation

@xdanger

@xdanger xdanger commented Mar 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Request Copilot code review via gh pr edit --add-reviewer @copilot instead of the copilot_code_review ruleset rule
  • Copilot reviews every PR automatically but as a regular reviewer — its COMMENTED state no longer blocks merges
  • Review threads still require resolution per required_review_thread_resolution

Context

The copilot_code_review ruleset rule was removed from trunk-guard because it blocked merges when Copilot left a COMMENTED review state (it never APPROVED). This approach gives the same review coverage without the merge blocker.

Test plan

  • Open a test PR and verify Copilot is automatically requested as a reviewer
  • Verify Copilot review comments appear but do not block merge after resolution

🤖 Generated with Claude Code

- Use `gh pr edit --add-reviewer @copilot` instead of the
  `copilot_code_review` ruleset rule which blocks merges
- Copilot comments still require resolution but won't gate merge state

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@xdanger xdanger self-assigned this Mar 28, 2026
- Rename from `claude-code-review.yml` to `code-review.yml` since
  the workflow now includes both Claude and Copilot reviews
- Update workflow name and README references accordingly

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f87696747d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- `gh pr edit` fails without a git repo; use `-R` to specify the repo
  explicitly instead of requiring a checkout step

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
github-actions Bot requested a review from Copilot March 28, 2026 21:40
@xdanger
xdanger removed the request for review from Copilot March 28, 2026 21:40
@xdanger
xdanger merged commit 80a72ae into main Mar 28, 2026
3 checks passed
@xdanger
xdanger deleted the add-copilot-reviewer branch March 28, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant