Skip to content

🔧 chore(deps): bump lint-staged - #17

Merged
xdanger merged 1 commit into
mainfrom
codex/bump-lint-staged-17
May 14, 2026
Merged

xdanger merged 1 commit into
mainfrom
codex/bump-lint-staged-17

Conversation

@xdanger

@xdanger xdanger commented May 14, 2026

Copy link
Copy Markdown
Member

Summary

  • bump lint-staged from ^16.4.0 to ^17.0.4
  • refresh the focused pnpm lockfile entries for its dependency graph

Risk

  • lint-staged 17 raises the Node engine requirement from >=20.17 to >=22.22.1; this repo has no lower Node pin, and local validation ran on Node 24.14.0
  • no config migration was needed for the existing .lintstagedrc.mjs

Validation

  • pnpm install --frozen-lockfile
  • pnpm run lint
  • pnpm exec lint-staged --version
  • pnpm outdated --format json

- 🔧 require the current lint-staged major for dev tooling
@claude

claude Bot commented May 14, 2026

Copy link
Copy Markdown

✅ Approved

No new findings.

Clean dependency bump of lint-staged from ^16.4.0 to ^17.0.4. Lockfile changes are consistent — removed dependencies (colorette, commander) that lint-staged 17 no longer uses, updated transitive deps (listr2 9→10, tinyexec 1.0→1.1, yaml 2.8→2.9), added wrap-ansi@10.0.0. The Node engine requirement increase (>=20.17 → >=22.22.1) is acknowledged in the PR description with no conflicting version pins in the repo.

@greptile-apps

greptile-apps Bot commented May 14, 2026 •

Copy link
Copy Markdown

Greptile Summary

此 PR 将 lint-staged 从 ^16.4.0 升级到 ^17.0.4,并同步刷新 pnpm 锁文件中的依赖图(listr2、tinyexec、yaml、wrap-ansi 均有对应版本更新)。

  • lint-staged@17 的最低 Node.js 引擎要求从 >=20.17 跳升到 >=22.22.1(listr2@10 要求 >=22.13.0);package.json 目前无 engines 字段,建议补充以显式声明约束。
  • yaml 从直接依赖降级为 optionalDependencies;因本仓库使用 .lintstagedrc.mjs,此变化无实际影响。
  • commander 和 colorette 依赖被完全移除,属于上游内部清理,无需本仓库做任何配置迁移。

Confidence Score: 4/5

升级本身是直接的依赖版本提升,锁文件与声明一致,现有 .lintstagedrc.mjs 配置无需修改,可安全合并。

变更仅涉及 lint-staged 的版本提升,锁文件完整且自洽。唯一值得关注的是 Node.js 最低版本要求从 20.17 跳升到 22.22.1,而 package.json 缺少 engines 字段来向贡献者传达这一约束——在低版本 Node 环境下调用 lint-staged 会导致意外失败。

package.json — 建议补充 engines 字段以文档化 Node >=22.22.1 的要求

Important Files Changed

Filename Overview
package.json 将 lint-staged 从 ^16.4.0 升级到 ^17.0.4;缺少 engines 字段来声明新的 Node >=22.22.1 要求
pnpm-lock.yaml 锁文件正确反映了 lint-staged@17.0.4 的依赖图:commander 和 colorette 移除,yaml 改为 optionalDependencies,listr2/tinyexec/wrap-ansi 同步升级

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["lint-staged@17.0.4\nNode >=22.22.1"] --> B["listr2@10.2.1\nNode >=22.13.0"]
    A --> C["picomatch@4.0.4"]
    A --> D["string-argv@0.3.2"]
    A --> E["tinyexec@1.1.2\nNode >=18"]
    A --> F["yaml@2.9.0\n(optional)"]
    B --> G["cli-truncate@5.2.0"]
    B --> H["eventemitter3@5.0.4"]
    B --> I["log-update@6.1.0"]
    B --> J["rfdc@1.4.1"]
    B --> K["wrap-ansi@10.0.0\nNode >=20"]

    subgraph "已移除"
      L["commander@14.0.3"]
      M["colorette@2.0.20"]
    end
Loading

Comments Outside Diff (1)

  1. package.json, line 10 (link)

    P1 lint-staged@17 将最低 Node.js 版本要求从 >=20.17 提升到 >=22.22.1(通过 listr2@10 传递依赖进一步要求 >=22.13.0)。package.json 目前没有 engines 字段,贡献者在 Node 20.x 或 21.x 环境下运行 lint-staged 时会静默失败或收到难以排查的错误。建议补充 engines 字段以明确记录此约束。

    Fix in Codex Fix in Claude Code

Fix All in Codex Fix All in Claude Code

Reviews (1): Last reviewed commit: "🔧 chore(deps): bump lint-staged" | Re-trigger Greptile

@xdanger
xdanger merged commit c6c8ec2 into main May 14, 2026
7 checks passed
@xdanger
xdanger deleted the codex/bump-lint-staged-17 branch May 14, 2026 09:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repo’s developer tooling by bumping lint-staged to the latest major version and regenerating the corresponding pnpm-lock.yaml entries to reflect the updated dependency graph.

Changes:

  • Bump lint-staged from ^16.4.0 to ^17.0.4 in package.json.
  • Refresh pnpm-lock.yaml to capture lint-staged@17 and transitive dependency updates (e.g., listr2, tinyexec, yaml, wrap-ansi) and removals (e.g., commander, colorette).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Updates lint-staged dependency to ^17.0.4.
pnpm-lock.yaml Regenerates lockfile entries for lint-staged@17 and updated transitive dependencies (including new Node engine constraints).
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
"globals": "^17.6.0",
"husky": "^9.1.7",
"lint-staged": "^16.4.0",
"lint-staged": "^17.0.4",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants