Skip to content

Assignment 1#1

Open
tanveerrouf wants to merge 2 commits intomainfrom
assignment-1
Open

Assignment 1#1
tanveerrouf wants to merge 2 commits intomainfrom
assignment-1

Conversation

@tanveerrouf
Copy link
Owner

@tanveerrouf tanveerrouf commented Nov 24, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Built KNN classifier on Wine dataset with standardized features, train/test split, and GridSearchCV hyperparameter tuning.

What did you learn from the changes you have made?

GridSearchCV efficiently finds optimal n_neighbors and distance-based algorithms require feature standardization before splitting.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Manual hyperparameter testing would be slower and riskier for overfitting.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Non-fast-forward rejection on push. Resolved with git pull origin assignment-1 then pushed successfully.

How were these changes tested?

Non-fast-forward rejection on push. Resolved with git pull origin assignment-1 then pushed successfully.

A reference to a related issue in your repository (if applicable)

None.

Checklist

  • [Y] I can confirm that my changes are working as intended

Copy link

@PatelVishakh PatelVishakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment 1: Complete. Great work!
Suggested Changes:
Q1)III) The type of variable is categorical. In a data science setting, this question is asking whether the variable is continuous or categorial(integer, ordinal are other options).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments