Open
Conversation
PatelVishakh
approved these changes
Nov 27, 2025
PatelVishakh
left a comment
There was a problem hiding this comment.
Assignment 1: Complete. Great work!
Suggested Changes:
Q1)III) The type of variable is categorical. In a data science setting, this question is asking whether the variable is continuous or categorial(integer, ordinal are other options).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Built KNN classifier on Wine dataset with standardized features, train/test split, and GridSearchCV hyperparameter tuning.
What did you learn from the changes you have made?
GridSearchCV efficiently finds optimal n_neighbors and distance-based algorithms require feature standardization before splitting.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Manual hyperparameter testing would be slower and riskier for overfitting.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Non-fast-forward rejection on push. Resolved with git pull origin assignment-1 then pushed successfully.
How were these changes tested?
Non-fast-forward rejection on push. Resolved with git pull origin assignment-1 then pushed successfully.
A reference to a related issue in your repository (if applicable)
None.
Checklist