This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Small codegen improvements. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not need to look at the class' `kind`. The `jsNativeLoadSpec` is enough.
Previously, we tried to avoid useless casts based on IR subtyping rules. Now, we do it based on Wasm type equality. Moreover, if we do need to cast, we only use a direct RefCast, rather than `unboxOrNull` helpers for hijacked classes. The new scheme has several advantages: * It avoids more useless casts. For example, it avoids downcasts to interface types when the source type is not an ancestor of a hijacked class, since they all translate to `(ref null jl.Object)`. * The code is much simpler. * It avoids an expensive IR subtyping test, which would also not survive well if we get to make the backend incremental. As is, some casts can be introduced when they were not necessary before. However, such cases are rare, and will be truly gone when we can enable the optimizer.
Previously, we first created the struct with zero's, then assigned fields from the source one by one. We now load all the fields from the source onto the stack, then directly use `struct.new` to allocate the target. It might not necessarily be more efficient, but it definitely results is smaller code.
tanishiking
approved these changes
May 21, 2024
Comment on lines
+1748
to
+1749
| * rules, there is no pair `(sourceTpe, targetTpe)` for which the Wasm | ||
| * types are equal but a valid cast would require a *conversion*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.