feat(tangle-cloud): blueprint deployment request args configuration & finalization #2957

danielbui12 · 2025-04-07T14:01:32Z

Summary of changes

Provide a detailed description of proposed changes.

Implement request Args configuration step
Implement finalization step

Proposed area of change

Put an x in the boxes that apply.

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Closes [TASK] Instance Custom Parameters Inputs #2552

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

Screen.Recording.2025-04-12.at.09.39.12.mov

…tion step

netlify · 2025-04-07T14:01:51Z

✅ Deploy Preview for tangle-leaderboard ready!

Name	Link
🔨 Latest commit	`67d42c8`
🔍 Latest deploy log	https://app.netlify.com/sites/tangle-leaderboard/deploys/67fee9017f4e020008e5f0e4
😎 Deploy Preview	https://deploy-preview-2957--tangle-leaderboard.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-04-07T14:01:56Z

✅ Deploy Preview for tangle-dapp ready!

Name	Link
🔨 Latest commit	`67d42c8`
🔍 Latest deploy log	https://app.netlify.com/sites/tangle-dapp/deploys/67fee9018fda32000983a0ad
😎 Deploy Preview	https://deploy-preview-2957--tangle-dapp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-04-07T14:02:23Z

✅ Deploy Preview for tangle-cloud ready!

Name	Link
🔨 Latest commit	`67d42c8`
🔍 Latest deploy log	https://app.netlify.com/sites/tangle-cloud/deploys/67fee9019fb92900089c9676
😎 Deploy Preview	https://deploy-preview-2957--tangle-cloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

apps/tangle-cloud/src/data/services/useServiceRequestTx.ts

AtelyPham · 2025-04-12T13:29:23Z

apps/tangle-cloud/src/data/services/useServiceRequestTx.ts

+          context.securityRequirements[index].minExposurePercent,
+        maxExposurePercent:
+          context.securityRequirements[index].maxExposurePercent,


Should have a check or assertion to ensure context.securityRequirements has the same length as context.assets.

added to zod schema apps/tangle-cloud/src/utils/validations/deployBlueprint.ts:191:199

apps/tangle-cloud/src/data/services/useServiceRequestTx.ts

AtelyPham · 2025-04-12T14:14:38Z

apps/tangle-cloud/src/data/services/useServiceRequestTx.ts

+    Context
+  > = useCallback(
+    async (context) => {
+      const api = await getApiPromise(wsRpcEndpoint);


To keep a single source of truth, we could pass the API to the factory instead of using getApiPromise (which caches it).

Another option is to investigate how TypeScript encodes these types, but that could take more time.

Another option is to investigate how TypeScript encodes these types, but that could take more time

Dont think so 😂, cuz we generated types for easier usage, why dont we leverage it instead of try to re-write existing logic in PAPI

apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/AssetConfigurationStep.tsx

apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/BasicInformationStep.tsx

AtelyPham

Left some change suggestions.

apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/BasicInformationStep.tsx

libs/tangle-shared-ui/src/data/blueprints/useServicePalletConfig.ts

AtelyPham · 2025-04-12T14:37:12Z

libs/tangle-shared-ui/src/hooks/useAssets.ts

The logic in useRestakeAssets is highly similar to existing logic. Refactor into a reusable hook and use it within useRestakeAssets.

This hook is used to get all asets not only restake assets

libs/tangle-shared-ui/src/hooks/useAssetsMetadata.ts

libs/tangle-shared-ui/src/utils/createAssetIdEnum.ts

libs/ui-components/src/utils/toEvmAddress.ts

apps/tangle-cloud/src/data/services/useServiceRequestTx.ts

apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/BasicInformationStep.tsx

apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/OperatorSelectionStep.tsx

...e-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/components/AssetRequirementFormItem.tsx

apps/tangle-cloud/src/pages/blueprints/[id]/deploy/page.tsx

…eployment-request-args-configuration

…configuration

apps/tangle-cloud/src/components/InstanceHeader.tsx

yuri-xyz · 2025-04-14T22:08:34Z

apps/tangle-cloud/src/data/services/useServicesRegisterTx.ts

+const useServicesRegisterTx = () => {
+  const substrateTxFactory: SubstrateTxFactory<Context> = useCallback(
+    async (api, _activeSubstrateAddress, context) => {
+      const { blueprintIds, preferences, registrationArgs, amounts } = context;
+
+      // TODO: Find a better way to get the chain decimals
+      const decimals =
+        api.registry.chainDecimals.length > 0
+          ? api.registry.chainDecimals[0]
+          : TANGLE_TOKEN_DECIMALS;


You can import the network and get the decimals from it: useNetworkStore

but it results in a recursive hook within a hook. @AtelyPham do you have any idea?

@danielbui12 using custom hooks within custom hooks is totally normal & common practice, if that's what you meant. Think about it like functions within functions -- it makes sense, it's simply building blocks reusing each other

any update here? @danielbui12

apps/tangle-cloud/src/data/services/useServicesRegisterTx.ts

libs/tangle-shared-ui/src/data/blueprints/useBlueprintRegisteredOperator.ts

libs/tangle-shared-ui/src/data/blueprints/useServicePalletConfig.ts

libs/tangle-shared-ui/src/hooks/useAssets.ts

libs/ui-components/src/utils/toEvmAddress.ts

libs/tangle-shared-ui/src/hooks/useAssetsMetadata.ts

yuri-xyz · 2025-04-15T23:16:08Z

conflicts @danielbui12

danielbui12 · 2025-04-15T23:21:05Z

@yuri-xyz resolved. please take a time to verify my pr 🙏

yuri-xyz · 2025-04-15T23:24:45Z

merging, if anything's left over, feel free to solve in your next pr

danielbui12 added 13 commits April 4, 2025 15:29

feat(tangle-cloud): config asset security commitment

91669f1

chore(tangle-cloud): format code

69d5320

fix(libs/tangle-shared-ui): update type of useAssetsMetadata

5024c41

fix(tangle-cloud): update layout blueprint deployment asset configura…

1565e6c

…tion step

chore(tangle-cloud): format code

103c5dd

fix(tangle-cloud): refactor operator selection table

2d7eb11

chore(tangle-cloud): format code

1a89c84

fix(tangle-cloud): filter operator by selected asset

994f69f

chore(tangle-cloud): format code

9f6fc95

chore(tangle-cloud): fix typecheck error

91b1366

feat(tangle-cloud): review blueprint deployment step

542354e

chore(tangle-cloud): foramt code

ca5f1d8

chore(tangle-cloud): foramt code

b7b936a

danielbui12 added app: tangle-cloud ☁️ WIP 🚧 labels Apr 7, 2025

danielbui12 self-assigned this Apr 7, 2025

danielbui12 added 11 commits April 8, 2025 16:23

refactor(tangle-cloud): refactor blueprint deployment page

b702c82

chore(tangle-cloud): format code

05c9a58

chore(tangle-cloud): rebase develop & resolve conflicts

5e00f67

fix(tangle-cloud): update UI blueprint deployment

ce63daa

chore(tangle-cloud): format code

35d9dd7

fix(tangle-cloud): fetch related asset for each section

2219d1f

chore(tangle-cloud): format code

6c219bc

feat(tangle-cloud): send services precompile tx

8948e8a

chore(tangle-cloud): format code

c1bb01b

chore(tangle-cloud): lint code

4993916

chore(tangle-cloud): format code

8dab91a

AtelyPham reviewed Apr 12, 2025

View reviewed changes

apps/tangle-cloud/src/data/services/useServiceRequestTx.ts Outdated Show resolved Hide resolved

AtelyPham reviewed Apr 12, 2025

View reviewed changes

apps/tangle-cloud/src/data/services/useServiceRequestTx.ts Outdated Show resolved Hide resolved

AtelyPham reviewed Apr 12, 2025

View reviewed changes

apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/AssetConfigurationStep.tsx Outdated Show resolved Hide resolved

apps/tangle-cloud/src/pages/blueprints/[id]/deploy/DeploySteps/BasicInformationStep.tsx Outdated Show resolved Hide resolved

AtelyPham requested changes Apr 12, 2025

View reviewed changes

yuri-xyz requested changes Apr 12, 2025

View reviewed changes

chore(tangle-cloud): resolve pr comments

5f6e410

danielbui12 requested review from AtelyPham and yuri-xyz April 13, 2025 03:14

danielbui12 and others added 3 commits April 13, 2025 10:17

chore(tangle-cloud): rename services hooks

b139beb

Merge remote-tracking branch 'origin/develop' into daniel/blueprint-d…

e74a3fe

…eployment-request-args-configuration

Merge branch 'develop' into daniel/blueprint-deployment-request-args-…

ad6985f

…configuration

yuri-xyz requested changes Apr 15, 2025

View reviewed changes

danielbui12 added 6 commits April 15, 2025 09:49

chore(tangle-cloud): resolve pr comments

3996aa7

chore(tangle-cloud): foramt code

240fea7

chore(tangle-cloud): format code

c952e4a

chore(tangle-cloud): fix error type globalPricingForm

9fe12cb

chore(tangle-cloud): format code

71dbec5

fix(libs/tangle-shared-ui): fix logic of returning asset metadata

c38bae2

danielbui12 commented Apr 15, 2025

View reviewed changes

libs/tangle-shared-ui/src/hooks/useAssetsMetadata.ts Show resolved Hide resolved

danielbui12 requested a review from yuri-xyz April 15, 2025 04:20

fix(tangle-shared-ui): Update Tx Eligible Check (#2969)

58eb52c

chore(tangle-cloud): resolve conflicts

67d42c8

yuri-xyz approved these changes Apr 15, 2025

View reviewed changes

yuri-xyz merged commit 587c073 into develop Apr 15, 2025
20 checks passed

yuri-xyz deleted the daniel/blueprint-deployment-request-args-configuration branch April 15, 2025 23:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tangle-cloud): blueprint deployment request args configuration & finalization #2957

feat(tangle-cloud): blueprint deployment request args configuration & finalization #2957

danielbui12 commented Apr 7, 2025 •

edited

Loading

netlify bot commented Apr 7, 2025 •

edited

Loading

netlify bot commented Apr 7, 2025 •

edited

Loading

netlify bot commented Apr 7, 2025 •

edited

Loading

AtelyPham Apr 12, 2025

danielbui12 Apr 13, 2025

AtelyPham Apr 12, 2025

danielbui12 Apr 13, 2025 •

edited

Loading

AtelyPham left a comment

AtelyPham Apr 12, 2025

danielbui12 Apr 13, 2025

yuri-xyz Apr 14, 2025

danielbui12 Apr 15, 2025

yuri-xyz Apr 15, 2025

yuri-xyz Apr 15, 2025

yuri-xyz commented Apr 15, 2025

danielbui12 commented Apr 15, 2025

yuri-xyz commented Apr 15, 2025

feat(tangle-cloud): blueprint deployment request args configuration & finalization #2957

feat(tangle-cloud): blueprint deployment request args configuration & finalization #2957

Conversation

danielbui12 commented Apr 7, 2025 • edited Loading

Summary of changes

Proposed area of change

Associated issue(s)

Screen Recording

netlify bot commented Apr 7, 2025 • edited Loading

✅ Deploy Preview for tangle-leaderboard ready!

netlify bot commented Apr 7, 2025 • edited Loading

✅ Deploy Preview for tangle-dapp ready!

netlify bot commented Apr 7, 2025 • edited Loading

✅ Deploy Preview for tangle-cloud ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danielbui12 Apr 13, 2025 • edited Loading

Choose a reason for hiding this comment

AtelyPham left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yuri-xyz commented Apr 15, 2025

danielbui12 commented Apr 15, 2025

yuri-xyz commented Apr 15, 2025

danielbui12 commented Apr 7, 2025 •

edited

Loading

netlify bot commented Apr 7, 2025 •

edited

Loading

netlify bot commented Apr 7, 2025 •

edited

Loading

netlify bot commented Apr 7, 2025 •

edited

Loading

danielbui12 Apr 13, 2025 •

edited

Loading