Skip to content

fixed microphone letters in mode_indicator for windows #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixed microphone letters in mode_indicator for windows #1960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0255158
fixed microphone letters in mode_indicator for windows
DonnerWolfBach Aug 4, 2025
bbb3a4a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion plugin/mode_indicator/mode_indicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,13 @@ def on_draw(c: SkiaCanvas):
Point2d(x, y), radius, [color_text, color_text]
)

text = current_microphone[:2]
text = current_microphone
# on windows the current_microphone string always starts with "microphone (..."
Copy link
Collaborator

@AndreasArvidsson AndreasArvidsson Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually true. In windows you can rename your audio devices to whatever you want. Even without renaming them there exists microphones out there that have names that doesn't start with microphone.

We think it's probably easier for you to just rename your microphones so they each start with a unique letter.
We should probably add a comment write above the setting to enable the microphone name in the mode indicator telling people to rename their microphone in this case.
Does that sound reasonable?

Copy link
Contributor Author

@DonnerWolfBach DonnerWolfBach Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that is interesting, did not know that.

Indeed one of my headset calls itself "headset microphone (...)".

For me renaming microphones would be a bit of a chore since I have some more and switch computers quite often, but I think the possibility should be definitely mentioned.

I will most definitely keep my little dirty fix on my fork, maybe it makes sense to hide it behind another option for the community? Might provide a nicer out of the box experience if instead of renaming your microphone (clean but a bit more effort in setup - everytime you connect a new mic) you could also activate this little hack (not guaranteed to work always but a bit easier).

But I dont have strong opinions on that.

Copy link
Collaborator

@AndreasArvidsson AndreasArvidsson Aug 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a setting and then actually check if the name contains parenthesis would be a decent solution.
Another solution would be to do a map the same way we have with overriding application names, but for microphones. That way you only have to change a csv file and would work for all platforms.

if app.platform == "windows":
text = text.split("(")[1]

text = text[:2]

c.paint.style = c.paint.Style.FILL
c.paint.color = color_text
text_rect = c.paint.measure_text(text)[1]
Expand Down