Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy import of kedro fastapi modules and configs #23

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

takikadiri
Copy link
Owner

@takikadiri takikadiri commented Feb 13, 2024

Adress #22 without closing it

@takikadiri takikadiri self-assigned this Feb 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (5cacf45) 61.28% compared to head (8064812) 60.56%.

Files Patch % Lines
kedro_boot/app/fastapi/app.py 0.00% 8 Missing ⚠️
kedro_boot/app/fastapi/starter_apps/runner.py 0.00% 7 Missing ⚠️
kedro_boot/app/fastapi/session.py 0.00% 3 Missing ⚠️
kedro_boot/app/fastapi/cli.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   61.28%   60.56%   -0.72%     
==========================================
  Files          27       26       -1     
  Lines         842      852      +10     
==========================================
  Hits          516      516              
- Misses        326      336      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takikadiri takikadiri merged commit afeaa62 into main Feb 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants