Fixed bug with getWeekId #112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't tested, but it looks like a reasonable patch. I'd rather replace all the methods that modify the |
diogenesl
added a commit
to diogenesl/jQuery.Gantt
that referenced
this pull request
Sep 15, 2014
Fixes bugs: Weekly scale showing week zero in some situations (taitems#112) Weekly scale not showing correct number of weeks (52 or 53) (taitems#99) Daily scale showing day 1 inside the previous month group PS: This is my first GitHub contribuition, hope that I'm doing everything right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theres an apparent bug in getWeekId (Dec 31, 2013 would give 'dh-2013-0' instead of...'dh-2014-0'). This appears to be because getDayForWeek might move to the next year (week 0 may include some dates from the previous year). The if (m === 11 && w === 1) { appeared to be a workaround, but doesnt work because week numbers start at 0. However just basing the id of getDayForWeek() seems to fix it and be simpler.