Perform CSS variable resolution recursively #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
commented
Feb 4, 2025
| seen.add(key) | ||
| i -= 1 | ||
| } | ||
| } |
There was a problem hiding this comment.
@RobinMalfait or @philipp-spiess can y'all think of a way to break this? It has the potential for infinite recursion (due to circular theme key lookups) but I guarded against it here.
I think this should be sufficient but if you could give it some thought that would be much appreciated.
packages/tailwindcss-language-service/src/util/rewriting/replacements.ts
Show resolved
Hide resolved
philipp-spiess
approved these changes
Feb 5, 2025
thecrypticace
force-pushed
the
feat/recursive-lookups
branch
from
b8e47d9 to
733c03a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1102