android: add INIT_WITH_AUTHKEY intent #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. adb shell am broadcast -n com.tailscale.ipn/.IPNReceiver -a com.tailscale.ipn.INIT_WITH_AUTHKEY --es authkey "my-super-secret-authkey" Signed-off-by: Brad Fitzpatrick <[email protected]>
|
Some corners were cut but it seems to work. |
raggi
reviewed
Aug 7, 2023
| @@ -60,6 +60,7 @@ | |||
| <intent-filter> | |||
| <action android:name="com.tailscale.ipn.CONNECT_VPN" /> | |||
| <action android:name="com.tailscale.ipn.DISCONNECT_VPN" /> | |||
| <action android:name="com.tailscale.ipn.INIT_WITH_AUTHKEY" /> | |||
There was a problem hiding this comment.
If I'm reading this correctly, any app can send a disconnect broadcast, then this and cause the device to join a particular tailnet. We need to make sure this intent is not callable or receivable by other applications.
There was a problem hiding this comment.
Would this be len(b.backend.ListProfiles()) == 0 ? If any authenticated profiles exist, whether actively logged in or not, then we wouldn't accept an authkey?
There was a problem hiding this comment.
Yeah I didn't finish this part.
|
Including video here too. Not shown, the ADB commands... Screen.Recording.2023-08-07.at.1.39.03.PM.mov |
|
Is this PR gonna be merged anytime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.
adb shell am broadcast -n com.tailscale.ipn/.IPNReceiver -a com.tailscale.ipn.INIT_WITH_AUTHKEY --es authkey "my-super-secret-authkey"