Skip to content

cgosqlite: remove allocs in bind_{int64,null,double} #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2023
Merged

cgosqlite: remove allocs in bind_{int64,null,double} #65

merged 1 commit into from
Mar 26, 2023

Conversation

@bradfitz
Copy link
Member

@bradfitz bradfitz commented Mar 26, 2023

Updates tailscale/corp#9919

@bradfitz bradfitz requested review from crawshaw and maisem March 26, 2023 17:50
@bradfitz
Copy link
Member Author

bradfitz commented Mar 26, 2023

I found this while adding bind parameters to #58

BTW, #58 is down to zero allocs now.

@bradfitz bradfitz merged commit 316bbe0 into main Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawshaw crawshaw Awaiting requested review from crawshaw

1 more reviewer

@maisem maisem maisem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bradfitz @maisem