- 
                Notifications
    You must be signed in to change notification settings 
- Fork 7
Add DisableFunction API #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
  File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|  | @@ -60,6 +60,11 @@ type DB interface { | |||||||||||||||
| // | ||||||||||||||||
| // If hook is nil, the hook is removed. | ||||||||||||||||
| SetWALHook(hook func(dbName string, pages int)) | ||||||||||||||||
| // DisableFunction disables an existing function (including built-ins) using | ||||||||||||||||
| // sqlite3_create_function. The name and numArgs must match the existing | ||||||||||||||||
| // function's signature. | ||||||||||||||||
| // | ||||||||||||||||
| 
      Comment on lines
    
      +63
     to 
      +66
    
   There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor nit 
        Suggested change
       
 It is probably also worth noting that we "disable" it by replacing that function name with a stub that does nothing, rather than making it report an error. That might be relevant to someone debugging. | ||||||||||||||||
| DisableFunction(name string, numArgs int) error | ||||||||||||||||
| } | ||||||||||||||||
|  | ||||||||||||||||
| // Stmt is an sqlite3_stmt* database connection object. | ||||||||||||||||
|  | ||||||||||||||||
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As written, this will also let you "create" new previously non-existing no-op functions. That's harmless, but someone who misspells the function name they wanted to disable could easily be confused as there's no error to say "that doesn't exist".
Is it practical to look up the requested function first, and use that to report an error if someone tries to "disable" a function that isn't there? (E.g., we could query
select name, narg from pragma_function_list where name = 'fname'). That would also have the incidental benefit that we wouldn't need to know the argument count a priori.Not positive it's worth it, but this should be uncommon enough that it might be worth the extra step.