fields: parse tagged fields in struct values and apply secrets to them #80
Conversation
creachadair
force-pushed
the
mjf/plugtype
branch
6 times, most recently
from
54a9141 to
9646968
Compare
fields/example_test.go
Outdated
| } | ||
| defer st.Close() | ||
|
|
||
| // Apply the requested secrets to the fields. |
There was a problem hiding this comment.
hm, having it as a separate package makes for an unfortunate 3-step dance to discover, register, then install the secrets. But I can't think of a better way that doesn't pull reflect sadness into the main setec client library...
There was a problem hiding this comment.
Based on our discussion in Slack, I reworked this a bit along that suggestion.
| // tagged name, separated with a slash ("/"). | ||
| // | ||
| // See [Fields] for a description of the struct tags and types recognized. | ||
| func ParseFields(v any, namePrefix string) (*Fields, error) { |
There was a problem hiding this comment.
Deliberately still exported? The example seems to point to usage that doesn't require the machinery to be exposed. Or are we keeping it as an alternative way to do this?
There was a problem hiding this comment.
I left it exported so that you can still apply secrets to a struct even if that struct isn't available when the store is constructed. I reworked the examples and the docs to focus on the pre-declared case, but in some of our existing use we wouldn't be able to do this, because we don't get the struct until later.
Given a pointer to a struct with specially-tagged fields, use reflection to locate these fields and plumb secrets from a setec.Store into them.
creachadair
force-pushed
the
mjf/plugtype
branch
from
0641a00 to
36230c7
Compare
Given a pointer to a struct with specially-tagged fields, use reflection to
locate these fields and plumb secrets from a setec.Store into them.