client: fix corner cases in secret declaration #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Don't allow an empty secret name to be declared. While in principle this could be fine, it is weird and not worth supporting. 2. Deduplicate secret names before initialization. I originally thought this was not needed, but because of the way we merge cached results with the initialization step, duplicates can "poison" the initialization state.
patrickod
approved these changes
Oct 25, 2024
| // Although the constructor puts them into a map, duplicates can "poison" | ||
| // the initialization, so remove them up front. | ||
| slices.Sort(sec) | ||
| sec = slices.Compact(sec) |
There was a problem hiding this comment.
It's relatively new!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't allow an empty secret name to be declared. While in principle this
could be fine, it is weird and not worth supporting.
Deduplicate secret names before initialization. I originally thought this
was not needed, but because of the way we merge cached results with the
initialization step, duplicates can "poison" the initialization state.