README: add note about required oauth scopes #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #143. Signed-off-by: Naman Sood <[email protected]>
creachadair
approved these changes
Nov 22, 2024
README.md
Outdated
| @@ -17,6 +17,8 @@ Subsequent steps in the Action can then access nodes in your Tailnet. | |||
| oauth-client-id and oauth-secret are an [OAuth client](https://tailscale.com/s/oauth-clients/) | |||
| for the tailnet to be accessed. We recommend storing these as | |||
| [GitHub Encrypted Secrets.](https://docs.github.com/en/actions/security-guides/encrypted-secrets) | |||
| Note that any OAuth clients used for this purpose must have the | |||
There was a problem hiding this comment.
Nit: I'd suggest dropping "Note that any" here.
Suggested change
| Note that any OAuth clients used for this purpose must have the | |
| OAuth clients used for this purpose must have the |
but YMMV.
Signed-off-by: Naman Sood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143.