Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/bsky-webhook: don't log opaque bytes on error #8

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

creachadair
Copy link
Member

An error in a Jetstream message currently logs the raw message as bytes, which
the slog output renders as [01 02 03 ...] format. This is noisy, and also hard
to debug, so let's truncate them and quote them for the logger.

@creachadair creachadair requested a review from Erisa November 18, 2024 17:40
An error in a Jetstream message currently logs the raw message as bytes, which
the slog output renders as [01 02 03 ...] format. This is noisy, and also hard
to debug, so let's truncate them and quote them for the logger.
Copy link
Member

@Erisa Erisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Erisa Erisa merged commit f1965fb into main Nov 18, 2024
1 check passed
@Erisa Erisa deleted the mjf/claro branch November 18, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants