Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest #310

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Update manifest #310

merged 1 commit into from
Dec 20, 2023

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Dec 20, 2023

Auto-generated by create-pull-request.

This will be auto-merged when CI has passed because this is an auto-generated PR in a defined format and is usually considered no additional review is required.

@taiki-e taiki-e enabled auto-merge (rebase) December 20, 2023 06:07
@taiki-e taiki-e merged commit 900d5c4 into main Dec 20, 2023
26 checks passed
@taiki-e taiki-e deleted the update-manifest branch December 20, 2023 06:09
@NobodyXu
Copy link
Collaborator

There are so many PRs on this repo, since PR approval and merging is automated, maybe it's also a good idea to automate release?

@taiki-e
Copy link
Owner Author

taiki-e commented Dec 20, 2023

Well, the current release process is one command (./tools/publish <version>) by owner. It might be possible to automate it entirely if semver selection described in #94 could be automated, I don't have time to work on that for now.

@NobodyXu
Copy link
Collaborator

Hm, I think we could do that by triggering a new patch release after "Update manifest" is merged into main, by running workflow on main that checks the merged PR content?

In cargo-binstall we add a json wrapped in html comment for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants