Skip to content

Embed fix scroll - #6

Closed
taiebot wants to merge 305 commits into
mainfrom
Embed-fix-scroll-6
Closed

Embed fix scroll #6
taiebot wants to merge 305 commits into
mainfrom
Embed-fix-scroll-6

Conversation

@taiebot

@taiebot taiebot commented Jul 7, 2026

Copy link
Copy Markdown
Owner

No description provided.

AndyScherzinger and others added 30 commits May 15, 2026 15:32
…-rollup-linux-x64-gnu-4.x

chore(deps): update dependency @rollup/rollup-linux-x64-gnu to ^4.60.4 (main)
…ify-3.x

fix(deps): update dependency dompurify to ^3.4.3 (main)
…mathur-setup-php-2.x

chore(deps): update shivammathur/setup-php action to v2.37.1 (main)
…update-nextcloud-ocp

[main] Update nextcloud/ocp dependency
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
chore(deps): update dependency cypress to ^15.15.0 (main)
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
chore(deps): bump @nextcloud/vue from 8.38.0 to 8.39.0
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
...changing the action button to a 3-dot menu

AI-assistant: Claude Code v2.1.101 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.101 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.126 (Claude Sonnet 4.6)
AI-assistant: Claude Code v2.1.126 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.142 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…bedded tables

AI-assistant: Claude Code v2.1.142 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…sync import guard

ef3db38 tightened the userId guard in RowService::create() and ::updateSet()
from `=== null` to `=== null || === ''` to prevent async import background jobs
from silently creating rows without a real user in context.

However, the codebase intentionally uses an empty string as the public-context
sentinel: PublicRowOCSController calls setPublicContext(), which sets
$this->userId = '' in SuperService and $isPublicContext = true in
PermissionsService. PermissionsService::basisCheck() explicitly handles
$userId === '' by returning true when isPublicContext is set. The tightened
guard in ef3db38 rejected '' before it ever reached the permissions layer,
breaking row create and update for all public link shares.

The fix tracks the public context flag in SuperService itself via a new
$isPublicContext property, set alongside $this->userId = '' in
setPublicContext(). The guard in RowService is updated to:

  null              → always throws (DI never injected a user)
  '' + !publicCtx   → throws (background job running without a user — the
                       case ef3db38 was protecting against)
  '' + publicCtx    → passes (setPublicContext() was called intentionally)
  'alice'           → always passes (normal authenticated user)

Async imports remain protected because ImportTableJob never calls
setPublicContext(), so $isPublicContext stays false for that code path.

AI-assistant: Claude Code v2.1.143 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…update-nextcloud-ocp

[main] Update nextcloud/ocp dependency
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…ns should reflect a state (filled/outlined)

AI-assistant: Claude Code v2.1.143 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…con_and_TabIconState

🎨 Icons should be outline-variant where possible
samin-z and others added 29 commits July 1, 2026 17:15
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
…s-checkout-7.x

chore(deps): update actions/checkout action to v7 (main)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ight-monorepo

chore(deps): update dependency @playwright/test to ^1.61.1 (main)
…s-vite-1.x

chore(deps): update dependency cypress-vite to ^1.10.2 (main)
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
chore(deps): update dependency vite to ^7.3.6 (main)
…al-symbols-svg-400-0.x

fix(deps): update dependency @material-symbols/svg-400 to ^0.45.4 (main)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
chore(deps): update dependency cypress to ^15.18.0 (main)
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
…evers-share-after-delete

apply remove share for users/teams/groups
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…oud-pr-feedback-action-digest

chore(deps): update nextcloud/pr-feedback-action digest to c8c97a6 (main)
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
…s-io-github-action-7.x

chore(deps): update cypress-io/github-action action to v7.4.1 (main)
Signed-off-by: taiebot <dedreuil@yahoo.fr>
@taiebot taiebot closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.