Setup multi currency support #3822
Open
+921
−335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces "DisplayCurrency" which stores a user selected currency to use as reference for displaying and formatting balances and values across the wallet, e.g. fiat currencies or assets (e.g. BTC).
|
I'm working on some related stuff (locale-specific currency formatting, etc) over in |
Yes, this definitely looks like it'll come in handy! I'm currently testing around moving back to price points but this makes a lot of things simpler, thanks @mhluongo! |
Removes "convertUSDAmountToCurrency" in favor of converting asset price points into the user currency before formatting. cent is mostly providing currency metadata for now.
This adds a few contract addresses for EUR/AUD/JPY rates which should be good for testing. Also added a dropdown on the settings page to test switching between currencies that is yet to be wrapped under a feature flag.
Set dust threshold to $2 instead of using the user's selected currency to ensure consistent minimum value across currencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces "DisplayCurrency" which stores a user selected currency to use as reference for displaying and formatting balances and values across the wallet, e.g. fiat currencies or assets (e.g. BTC).
Testing env
Latest build: extension-builds-3822 (as of Wed, 08 Oct 2025 00:05:49 GMT).