Replace e2e fork node with anvil #3781
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes dependency on env vars and adds a script shortcut to run fork tests
This will come useful when we need a deterministic name for test assertions.
Previous approach would have missed updates if a price fetch was requested after detecting a new token balance. This also increases the frequency of price updates.
Since local nodes require higher gas to fulfill read only calls these would sometimes fail silently when done through multicall.
This updates fork tests to run on anvil instead of hardhat. The change significantly improves test speed and prevents hangups. Even for simple cases anvil performs better without a cache.
hyphenized
force-pushed
the
testing-tests-e2e-fork
branch
6 times, most recently
from
1c43fb9 to
089cc93
Compare
These should be consistent between local/ci
By sending sigint to the process this script will stall until anvil polled requests finish so it can flush the cache to disk before the job completes
These are meant to help identify price loading has completed for a given asset
Normalizes balances to ensure tests work when the CI account differs from the one used locallly
hyphenized
force-pushed
the
testing-tests-e2e-fork
branch
from
896beee to
402a6d9
Compare
|
You interested in help getting this over the line ser? Seems worthwhile |
Yes I agree, I was planning on bringing this back to life after the other PR since I have to spend some time syncing the CI cache... though perhaps I can find a way to do this faster now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates fork tests to run on anvil instead of hardhat. The change significantly improves test speed and prevents hangups. Even for simple cases anvil performs better without a cache.
Latest build: extension-builds-3781 (as of Mon, 24 Feb 2025 07:23:37 GMT).