fix: htmlの改善

taga3s · Apr 27, 2024 · ee40ca2 · ee40ca2
1 parent 51bd69f
commit ee40ca2
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 11 deletions.
diff --git a/.env.example b/.env.example
@@ -1,5 +1,7 @@
+#app
 VITE_API_ENDPOINT="http://localhost:3000/v1"
 
+#firebase
 VITE_FIREBASE_API_KEY=
 VITE_FIREBASE_AUTH_DOMAIN=
 VITE_FIREBASE_PROJECT_ID=

diff --git a/src/features/manage/components/ManageQuestCard.tsx b/src/features/manage/components/ManageQuestCard.tsx
@@ -55,7 +55,11 @@ export const ManageQuestCard: FC<Props> = (props) => {
       <div className="px-4 py-2">
         <div className="flex items-center py-2">
           <h1 className="font-bold text-lg text-rhyth-dark-blue">{title}</h1>
-          <button className="p-1 ml-auto" onClick={() => navigate({ to: `/manage/edit`, search: { quest_id: id } })}>
+          <button
+            type="button"
+            className="p-1 ml-auto"
+            onClick={() => navigate({ to: "/manage/edit", search: { quest_id: id } })}
+          >
             <div className="flex items-center gap-2 justify-center">
               <svg
                 className="w-6 h-6 text-rhyth-blue hover:text-rhyth-hover-blue"

diff --git a/src/features/manage/components/ManageTimetableCard.tsx b/src/features/manage/components/ManageTimetableCard.tsx
@@ -121,6 +121,7 @@ export const ManageTimetableCard: FC<Props> = (props) => {
                 <div className="flex items-center justify-between mb-2">
                   <p className="font-bold text-sm text-white bg-rhyth-gray py-1 px-3 rounded-lg tracking-wider">メモ</p>
                   <button
+                    type="button"
                     className="p-1 ml-auto"
                     onClick={() =>
                       navigate({

diff --git a/src/features/manage/edit/components/EditPresenter.tsx b/src/features/manage/edit/components/EditPresenter.tsx
@@ -148,10 +148,10 @@ export const EditPresenter: FC<Props> = (props) => {
               <div className="my-2">
                 <p className="block my-2 font-bold text-rhyth-gray">実施頻度</p>
                 <div className="flex mt-4 gap-1">
-                  {DAYS.map((day, i) => {
+                  {DAYS.map((day) => {
                     return (
                       <DayOfTheWeek
-                        key={i}
+                        key={day}
                         day={convertEnToJPWeekday(day)}
                         value={day}
                         register={register}

diff --git a/src/features/manage/new/components/NewPresenter.tsx b/src/features/manage/new/components/NewPresenter.tsx
@@ -124,10 +124,10 @@ export const NewPresenter = () => {
             <div className="my-2">
               <p className="block my-2 font-bold text-rhyth-gray">実施頻度</p>
               <div className="flex mt-4 gap-1">
-                {DAYS.map((day, i) => {
+                {DAYS.map((day) => {
                   return (
                     <DayOfTheWeek
-                      key={i}
+                      key={day}
                       day={convertEnToJPWeekday(day)}
                       value={day}
                       register={register}

diff --git a/src/features/manage/tags/components/TagsItem.tsx b/src/features/manage/tags/components/TagsItem.tsx
@@ -14,7 +14,7 @@ export const TagsItem: FC<Props> = ({ tagName, tagColor, onEditFn, onDeleteFn })
   return (
     <li className="h-12 flex items-center justify-between w-full border-b-2 border-rhyth-light-gray last:border-none px-4 py-2 rounded-t-lg">
       <div className="flex items-center">
-        <span className={`w-3 h-3 me-3 ${selectTagColorBg(tagColor)} rounded-full`}></span>
+        <span className={`w-3 h-3 me-3 ${selectTagColorBg(tagColor)} rounded-full`} />
         <p>{tagName}</p>
       </div>
       <div className="flex items-center gap-2">

diff --git a/src/features/profile/badges/components/badge/Badge.tsx b/src/features/profile/badges/components/badge/Badge.tsx
@@ -12,9 +12,9 @@ type Props = {
 export const Badge: FC<Props> = ({ imageType, frameColor }) => {
   return (
     <div className="relative w-full h-full overflow-hidden drop-shadow-lg">
-      <BadgeSparkling className={`absolute z-30`} />
-      <BadgeFrame frameColor={frameColor} className={`absolute z-20 scale-125`} />
-      <BadgeItem imageType={imageType} className={`absolute z-10 scale-50`} />
+      <BadgeSparkling className={"absolute z-30"} />
+      <BadgeFrame frameColor={frameColor} className={"absolute z-20 scale-125"} />
+      <BadgeItem imageType={imageType} className={"absolute z-10 scale-50"} />
     </div>
   );
 };
diff --git a/src/features/profile/components/ProfileLogoutModalButton.tsx b/src/features/profile/components/ProfileLogoutModalButton.tsx
@@ -7,7 +7,7 @@ type Props = {
 export const ProfileLogoutModalButton: FC<Props> = ({ onClickFn }) => {
   return (
     <div className="w-full text-sm font-medium text-rhyth-black bg-white hover:bg-rhyth-hover-light-gray border border-gray-200 rounded-b-lg shadow">
-      <button onClick={onClickFn} className="block w-full h-hull">
+      <button type="button" onClick={onClickFn} className="block w-full h-hull">
         <div className="px-4 py-3 flex gap-6 items-center">
           <div>
             <svg

diff --git a/src/features/profile/settings/components/SettingsImageCropModal.tsx b/src/features/profile/settings/components/SettingsImageCropModal.tsx
@@ -54,7 +54,7 @@ export const SettingsImageCropModal: FC<Props> = ({ imageUrl, closeModal, setPro
         </div>
         <div className="grid gap-3 p-4 md:p-4">
           <ReactCrop crop={crop} keepSelection onChange={(_, percentCrop) => setCrop(percentCrop)} aspect={1}>
-            <img ref={imgRef} src={imageUrl} onLoad={onImageLoad} />
+            <img ref={imgRef} src={imageUrl} onLoad={onImageLoad} alt="切り取られる対象の画像" />
           </ReactCrop>
           <div className="hidden">
             <canvas