Skip to content

Add a read_text implementation for async readers #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a read_text implementation for async readers #856

wants to merge 2 commits into from

Conversation

BitSyndicate1
Copy link

This adds a read_text_into_async method for Readers which allows writing the content in between nested tags to an arbitrary AsyncWriter, analogous to Reader::read_text and NsReader::read_text respectively.

Mingun
Mingun requested changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@Mingun Mingun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add tests to ensure that this will work as expected (especially check that trailing spaces are included in the text). Doc tests will be enougth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mingun Mingun Mingun requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BitSyndicate1 @Mingun