refactor(codegen): make selector hack compatible with TON API #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-trunov
changed the title
anton-trunov
requested changes
Mar 17, 2025
There was a problem hiding this comment.
You also need to fix the docs, see the internalExternalReceiversOutsideMethodsMap section here: https://docs.tact-lang.org/book/config/#options-optimizations.
And we need to mark it as a breaking change in the changelog.
…' into B4ckSl4sh/reworked-selector-hack
# Conflicts: # dev-docs/CHANGELOG.md # src/benchmarks/jetton/results_code_size.json # src/benchmarks/jetton/results_gas.json # src/benchmarks/notcoin/results_code_size.json # src/benchmarks/notcoin/results_gas.json # src/benchmarks/wallet/results_gas.json
|
@Shvandre, sorry that I've barged in with my changes — I just wanted to do docs. Those look fine now, you may continue with code issues :) |
…' into B4ckSl4sh/reworked-selector-hack # Conflicts: # src/benchmarks/jetton/results_code_size.json # src/benchmarks/jetton/results_gas.json # src/benchmarks/notcoin/results_code_size.json # src/benchmarks/notcoin/results_gas.json # src/benchmarks/wallet/results_gas.json
# Conflicts: # dev-docs/CHANGELOG.md
i582
approved these changes
Mar 20, 2025
verytactical
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2366 .