This repository was archived by the owner on Dec 12, 2024. It is now read-only.
Add details regarding abstract and virtual functions in traits #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-trunov
suggested changes
May 2, 2024
|
@Oni-giri Thanks for your contribution! Let's fix a couple of nits and we are good to go |
anton-trunov
previously approved these changes
May 7, 2024
|
@novusnota check my recent changes please |
novusnota
approved these changes
May 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed that the docs didn't include any mention of
virtualandabstractfunctions in traits, which can be overridden in the implementation contract. The virtual keyword for functions can be seen in an example in the Tact by Example website, for instance.This is a great feature of Tact, so I think it's worth it to include it in the official docs! I also added references to it in other pages which were relevant.